Repository navigation
The #325 lighting tests no longer depend on the project's shadow settings (#325) - #363
Merged
Merged
Conversation
APillarInARoom_ShadowsTheFloorFromALamp needed the project's render pipeline to let lights other than the main one cast shadows, and failed in a project where they don't. It now turns that on for its run and puts it back; without such a setting in the render pipeline it is skipped. When the baked lamp doesn't light the floor, the bake test's message says what the bake left: the lightmap's index and count, whether its texture and the lighting data are there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes and why
Two tests from #325 depended on more than their own setup:
APillarInARoom_ShadowsTheFloorFromALampneeded the project's render pipeline to let lights other than the main one cast shadows. In a project where they don't, the lamp casts no shadow and the test failed. It now turns that setting on for its run (URP'ssupportsAdditionalLightShadows, whose setter is internal) and puts it back afterwards; with a render pipeline that has no such setting it is skipped.ABakedLamp_LightsARoomAsACarvedOne_AndAgainAfterAnEdithas been seen to find the floor black after a bake, rarely. Its message now says what the bake left: the lightmap's index and count, whether its texture and the lighting data are there.Fixes #325
How it was tested (scene, steps, Unity version)
With the project's render pipeline not letting additional lights cast shadows, the pillar test failed (the floor 0.0792 with and without shadows) before the change and passes after it, in Unity 6.6 (6000.6.0f1) and Unity 7 (7000.0.0a12); the project's pipeline asset is unchanged afterwards.
ChiselSubtractiveWorkflowTests: 80 passed in both.